[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6
Date: Tue, 22 Mar 2016 08:41:13 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Samuel Thibault <address@hidden> writes:

> Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote:
>> Samuel Thibault <address@hidden> writes:
>> > Make net= disable IPv4 and ip6-net=:: disable IPv6, so the user can
>> > setup IPv4-only and IPv6-only network environments.
>> Do "net=" and "ip6-net=" mean anything useful?  If not, wouldn't that be
>> a more natural way to switch off than abusing the wildcard address?
> An empty parameter looks odd to me. is used e.g. by ifconfig to
> disable an interface, that's why I thought about it.  Perhaps an even
> better way would be net=none and ip6-net=none?

An empty string as parameter value looks just fine to me.  "none" would
be fine, too, because it's not a valid value so far.  I acknowledge the
precedence for abusing the wildcard address.  Pick something you like.

>> > @@ -2427,7 +2427,7 @@
>> >  #
>> >  # @ip: #optional legacy parameter, use net= instead
>> >  #
>> > -# @net: #optional IP address and optional netmask
>> > +# @net: #optional IP address and optional netmask. Set to to 
>> > disable IPv4 completely
>> Long line.
>> Syntax?  Default value?
> Well, that's what was there :)
> But yes I can add that along the way.  I'm however now wondering
> what difference is supposed to exist between the documentation in
> qapi-schema.json and in qemu-options.hx?  (I know they are separate
> software layers, thus the two documentations, but does it make sense to
> have differing documentations when the qapi schema and the CLI options
> work the same?)

If one of them covers something the other doesn't, chances are there's a
doc bug.

Perhaps we can some day define the command line language with a QAPI
schema, just like we define the QMP language now.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]