[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 33/40] ivshmem: Inline check_shm_size() into

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 33/40] ivshmem: Inline check_shm_size() into its only caller
Date: Fri, 18 Mar 2016 17:50:46 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Marc-André Lureau <address@hidden> writes:

> Hi
> On Tue, Mar 15, 2016 at 7:34 PM, Markus Armbruster <address@hidden> wrote:
>> Improve the error messages while there.
>> Signed-off-by: Markus Armbruster <address@hidden>
> I'd prefer we keep a seperate function to handle the shm checks, but I
> don't mind much so:

Matter of taste.  I respect yours, and considered all your suggestions,
but for this one, I really prefer the linear, "one check after the
other" flow.

> Reviewed-by: Marc-André Lureau <address@hidden>

Thanks for your review of all versions of this series.  You made a

reply via email to

[Prev in Thread] Current Thread [Next in Thread]