[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] tcg: code_bitmap is not used by user-mode e

From: Sergey Fedorov
Subject: Re: [Qemu-devel] [PATCH 1/5] tcg: code_bitmap is not used by user-mode emulation
Date: Thu, 17 Mar 2016 18:03:46 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 17/03/16 17:56, Peter Maydell wrote:
On 17 March 2016 at 13:46,  <address@hidden> wrote:
From: Paolo Bonzini <address@hidden>

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Sergey Fedorov <address@hidden>
  translate-all.c | 9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/translate-all.c b/translate-all.c
index e9f409b762ab..f17ace1ae899 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -784,6 +784,9 @@ void tb_free(TranslationBlock *tb)

  static inline void invalidate_page_bitmap(PageDesc *p)
+    assert(p->code_bitmap == NULL);
      p->code_bitmap = NULL;
      p->code_write_count = 0;
@@ -1018,6 +1021,7 @@ void tb_phys_invalidate(TranslationBlock *tb, 
tb_page_addr_t page_addr)
You could pretty much take this another step and actually
make the field in the struct be only present ifdef CONFIG_SOFTMMU...

Sonds a good idea.

Kind regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]