[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies

From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PATCH 6/9] log: log QMP commands and replies
Date: Wed, 16 Mar 2016 16:09:54 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 03/14/2016 07:40 PM, Paolo Bonzini wrote:

On 14/03/2016 17:16, Denis V. Lunev wrote:
BTW, I'm not against adding this to QEMU in general - just pointing out
that in the context of libvirt usage reference in the commit message,
it is not really needed. I'm totally ambivalent wrt adding this to QEMU
for benefit of non-libvirt usage.
I see. This just requires very clear commit message from my side.
Thank you for a discussion.
I think this is not a compelling usage of the logging subsystem; QMP is
always used through a character device, and character devices already
have a logging mechanism.

Adding a mechanism that looks for '\n' in the data written to a
character device and emits a timestamp on the next character would be a
useful addition.  I'd be entirely happy with adding it now, it should be
safe enough that we can do it during soft freeze.

really interesting approach with a good place to get in.
But we will need to modify this a infrastructure a bit.
Af far as I can see only data from VM to outside world
is logged. Data being 'read' should be logged too as far
as I could understand.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]