[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-arm] [PATCH] sd: Fix "info qtree" on boards with
Re: [Qemu-devel] [Qemu-arm] [PATCH] sd: Fix "info qtree" on boards with SD cards
Tue, 15 Mar 2016 20:41:38 +0000
On 15 March 2016 at 20:33, Peter Maydell <address@hidden> wrote:
> On 15 March 2016 at 20:28, Thomas Hanson <address@hidden> wrote:
>> The patch looks good.
>> Would it also be good to update bus_add_child() so that it NULL-checks
>> its "bus" parameter before dereferencing it?
> No, I think it's just a programming error to call qdev_set_parent_bus()
> with a NULL bus parameter, so crashing is fine.
...but it might be helpful to assert in qdev_try_create() that
if we're using the default bus then the object is a sysbus
device object. At least then the problem will be immediately
clear rather than only showing up if you run a monitor command