[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 14/15] Don't include qemu-common.h in headers
Date: Tue, 15 Mar 2016 20:03:14 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Peter Maydell <address@hidden> writes:

> On 15 March 2016 at 17:25, Paolo Bonzini <address@hidden> wrote:
>> Since I have your attention, what about getting rid of fprintf-fn.h and
>> moving it into qemu/osdep.h?
> Not a lot very osdep-ish about it... If you're going to put it anywhere
> then typedefs.h seems more appropriate.

Makes sense to me.

> (It's in its own file at the moment as part of a previous idea of
> cleaning up qemu-common.h by splitting it into separate parts where
> necessary so that only the needed parts could be included by the
> code that wanted them.)

Sensible idea, but fprintf_function is hardly worth its very own header.
typedefs.h should do nicely.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]