[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 4/4] hw/input/adb.c: implement QKeyCode suppo

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v4 4/4] hw/input/adb.c: implement QKeyCode support
Date: Sun, 13 Mar 2016 16:42:53 +0000

On 13 March 2016 at 16:39, Programmingkid <address@hidden> wrote:
> I did try this but a bunch of errors showed up.

> /include/migration/vmstate.h:248:48: error: invalid operands to binary - 
> (have 'uint8_t (*)[256]' and 'uint16_t (*)[128]')
>  #define type_check_array(t1,t2,n) ((t1(*)[n])0 - (t2*)0)
> /include/migration/vmstate.h:261:6: note: in expansion of macro 
> 'type_check_array'
>       type_check_array(_type, typeof_field(_state, _field), _num))
> So I'm not sure now changing the type to 16 bit is the best thing to do. It 
> would require a lot more changes to other files.

Right, you would need to also change the migration state
to say the array was 16 bit. (This is a migration compat
break, so awkward anyway.)

I made a typo in that email which unfortunately completely
reversed the meaning -- I meant to say "we should just
take option (b)"...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]