[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support

From: Programmingkid
Subject: Re: [Qemu-devel] [PATCH v4 0/4] Implement some QKeyCode support
Date: Fri, 11 Mar 2016 12:19:16 -0500

On Mar 11, 2016, at 12:14 PM, Eric Blake wrote:

> On 03/10/2016 07:24 PM, Programmingkid wrote:
>> This patchset adds QKeyCode support the adb and cocoa code. 
>> Note: you do not need to be on a Mac to test out the adb.c, qapi-schema.json,
>> and adb-keys.h files. Only the cocoa.m file changes are Mac specific.
>> If you are using Linux as a guest, then the xev command is what you could 
>> use to
>> test out these patches. For a Mac OS guest the Key Caps application would 
>> help
>> with testing out these patches.
>> John Arbuckle (4):
>>  cocoa.m
>>  qapi-schema.json
>>  adb-keys.h
>>  adb.c
> This isn't the typical git cover letter - git lists the titles of the
> four patches, not the basenames of the files modified by the patches.
> Also, you still didn't manage to get threading quite right; the series
> ended up as 5 top-level threads, which makes it harder to find things in
> mailers that sort by threads with most recent activity.

My git send-email is broken. I spend hours googling fixes that didn't work. The 
5 top-level issue is because I sent the patches using my emailer. I will 
remember next time to add the titles to the cover letter. 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]