[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] pc: acpi: remove AML for empty/not used GPE han
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] pc: acpi: remove AML for empty/not used GPE handlers |
Date: |
Fri, 11 Mar 2016 15:44:54 +0200 |
On Thu, Mar 03, 2016 at 02:56:35PM +0100, Igor Mammedov wrote:
> ACPI spec requires GPE handlers only for GPE events
> that hardware implements.
> So remove AML for not supported by QEMU device model
> events.
>
> Signed-off-by: Igor Mammedov <address@hidden>
Looks valid but is guest visible.
Repost after the release pls.
> ---
> hw/i386/acpi-build.c | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 453d61c..713083d 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -2009,8 +2009,6 @@ build_dsdt(GArray *table_data, GArray *linker,
> {
> aml_append(scope, aml_name_decl("_HID", aml_string("ACPI0006")));
>
> - aml_append(scope, aml_method("_L00", 0, AML_NOTSERIALIZED));
> -
> if (misc->is_piix4) {
> method = aml_method("_E01", 0, AML_NOTSERIALIZED);
> aml_append(method,
> @@ -2018,8 +2016,6 @@ build_dsdt(GArray *table_data, GArray *linker,
> aml_append(method, aml_call0("\\_SB.PCI0.PCNT"));
> aml_append(method, aml_release(aml_name("\\_SB.PCI0.BLCK")));
> aml_append(scope, method);
> - } else {
> - aml_append(scope, aml_method("_L01", 0, AML_NOTSERIALIZED));
> }
>
> method = aml_method("_E02", 0, AML_NOTSERIALIZED);
> @@ -2029,19 +2025,6 @@ build_dsdt(GArray *table_data, GArray *linker,
> method = aml_method("_E03", 0, AML_NOTSERIALIZED);
> aml_append(method, aml_call0(MEMORY_HOTPLUG_HANDLER_PATH));
> aml_append(scope, method);
> -
> - aml_append(scope, aml_method("_L04", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L05", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L06", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L07", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L08", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L09", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L0A", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L0B", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L0C", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L0D", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L0E", 0, AML_NOTSERIALIZED));
> - aml_append(scope, aml_method("_L0F", 0, AML_NOTSERIALIZED));
> }
> aml_append(dsdt, scope);
>
> --
> 1.8.3.1