[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 08/10] ipmi: add some local variables in ipmi_sdr
From: |
Cédric Le Goater |
Subject: |
[Qemu-devel] [PATCH v3 08/10] ipmi: add some local variables in ipmi_sdr_init |
Date: |
Thu, 10 Mar 2016 15:04:01 +0100 |
This patch adds a couple of variables to manipulate the raw sdr
entries. The const attribute is also removed on init_sdrs. This will
ease the introduction of a sdr loader using a file.
Signed-off-by: Cédric Le Goater <address@hidden>
Acked-by: Corey Minyard <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
---
hw/ipmi/ipmi_bmc_sim.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
Index: qemu-powernv.git/hw/ipmi/ipmi_bmc_sim.c
===================================================================
--- qemu-powernv.git.orig/hw/ipmi/ipmi_bmc_sim.c
+++ qemu-powernv.git/hw/ipmi/ipmi_bmc_sim.c
@@ -1683,7 +1683,7 @@ static void register_cmds(IPMIBmcSim *s)
ipmi_register_netfn(s, IPMI_NETFN_STORAGE, &storage_netfn);
}
-static const uint8_t init_sdrs[] = {
+static uint8_t init_sdrs[] = {
/* Watchdog device */
0x00, 0x00, 0x51, 0x02, 35, 0x20, 0x00, 0x00,
0x23, 0x01, 0x63, 0x00, 0x23, 0x6f, 0x0f, 0x01,
@@ -1696,17 +1696,22 @@ static void ipmi_sdr_init(IPMIBmcSim *ib
{
unsigned int i;
int len;
+ size_t sdrs_size;
+ uint8_t *sdrs;
- for (i = 0; i < sizeof(init_sdrs); i += len) {
+ sdrs_size = sizeof(init_sdrs);
+ sdrs = init_sdrs;
+
+ for (i = 0; i < sdrs_size; i += len) {
struct ipmi_sdr_header *sdrh;
- if ((i + IPMI_SDR_HEADER_SIZE) > sizeof(init_sdrs)) {
+ if (i + IPMI_SDR_HEADER_SIZE > sdrs_size) {
error_report("Problem with recid 0x%4.4x", i);
return;
}
- sdrh = (struct ipmi_sdr_header *) &init_sdrs[i];
+ sdrh = (struct ipmi_sdr_header *) &sdrs[i];
len = ipmi_sdr_length(sdrh);
- if ((i + len) > sizeof(init_sdrs)) {
+ if (i + len > sdrs_size) {
error_report("Problem with recid 0x%4.4x", i);
return;
}
- [Qemu-devel] [PATCH v3 00/10] ipmi: a couple of enhancements to the BMC simulator (round 2), Cédric Le Goater, 2016/03/10
- [Qemu-devel] [PATCH v3 01/10] ipmi: remove IPMI_CHECK_CMD_LEN() macro, Cédric Le Goater, 2016/03/10
- [Qemu-devel] [PATCH v3 04/10] ipmi: add rsp_buffer_set_error() helper, Cédric Le Goater, 2016/03/10
- [Qemu-devel] [PATCH v3 03/10] ipmi: remove IPMI_CHECK_RESERVATION() macro, Cédric Le Goater, 2016/03/10
- [Qemu-devel] [PATCH v3 02/10] ipmi: replace IPMI_ADD_RSP_DATA() macro with inline helpers, Cédric Le Goater, 2016/03/10
- [Qemu-devel] [PATCH v3 07/10] ipmi: remove the need of an ending record in the SDR table, Cédric Le Goater, 2016/03/10
- [Qemu-devel] [PATCH v3 05/10] ipmi: add a realize function to the device class, Cédric Le Goater, 2016/03/10
- [Qemu-devel] [PATCH v3 08/10] ipmi: add some local variables in ipmi_sdr_init,
Cédric Le Goater <=
- [Qemu-devel] [PATCH v3 09/10] ipmi: use a file to load SDRs, Cédric Le Goater, 2016/03/10
- [Qemu-devel] [PATCH v3 10/10] ipmi: provide support for FRUs, Cédric Le Goater, 2016/03/10
- [Qemu-devel] [PATCH v3 06/10] ipmi: use a function to initialize the SDR table, Cédric Le Goater, 2016/03/10