[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] quorum: Fix crash in quorum_ai
Re: [Qemu-devel] [Qemu-block] [PATCH 1/4] quorum: Fix crash in quorum_aio_cb()
Thu, 10 Mar 2016 11:10:48 +0100
Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)
On Wed 09 Mar 2016 05:54:55 PM CET, Max Reitz <address@hidden> wrote:
> On 09.03.2016 17:11, Alberto Garcia wrote:
>> quorum_aio_cb() emits the QUORUM_REPORT_BAD event if there's
>> an I/O error in a Quorum child. However sacb->aiocb must be
>> correctly initialized for this to happen. read_quorum_children() and
>> read_fifo_child() are not doing this, which results in a QEMU crash.
>> Signed-off-by: Alberto Garcia <address@hidden>
>> block/quorum.c | 12 +++++++-----
>> 1 file changed, 7 insertions(+), 5 deletions(-)
> Reviewed-by: Max Reitz <address@hidden>
> Although I'm wondering whether we could have just used acb->common.bs
> instead of sacb->aiocb->bs in quorum_aio_cb(). I guess that
> sacb->aiocb is supposed to be equal to &acb->common.
acb->common.bs is the Quorum BDS, sacb->aiocb->bs is the child BDS.