[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3 1/7] vfio: Start improving VFIO/EEH interface
From: |
Alex Williamson |
Subject: |
Re: [Qemu-devel] [PATCHv3 1/7] vfio: Start improving VFIO/EEH interface |
Date: |
Tue, 8 Mar 2016 18:36:48 -0700 |
On Wed, 9 Mar 2016 11:56:57 +1100
David Gibson <address@hidden> wrote:
> On Tue, Mar 08, 2016 at 11:33:45AM -0700, Alex Williamson wrote:
> > On Tue, 8 Mar 2016 13:10:23 +1100
> > David Gibson <address@hidden> wrote:
> >
> > > At present the code handling IBM's Enhanced Error Handling (EEH) interface
> > > on VFIO devices operates by bypassing the usual VFIO logic with
> > > vfio_container_ioctl(). That's a poorly designed interface with unclear
> > > semantics about exactly what can be operated on.
> > >
> > > In particular it operates on a single vfio container internally (hence the
> > > name), but takes an address space and group id, from which it deduces the
> > > container in a rather roundabout way. groupids are something that code
> > > outside vfio shouldn't even be aware of.
> > >
> > > This patch creates new interfaces for EEH operations. Internally we
> > > have vfio_eeh_container_op() which takes a VFIOContainer object
> > > directly. For external use we have vfio_eeh_as_ok() which determines
> > > if an AddressSpace is usable for EEH (at present this means it has a
> > > single container with exactly one group attached), and vfio_eeh_as_op()
> > > which will perform an operation on an AddressSpace in the unambiguous
> > > case,
> > > and otherwise returns an error.
> > >
> > > This interface still isn't great, but it's enough of an improvement to
> > > allow a number of cleanups in other places.
> > >
> > > Signed-off-by: David Gibson <address@hidden>
> > > Reviewed-by: Alexey Kardashevskiy <address@hidden>
> > > ---
> >
> > I'll let you push this through your tree:
> >
> > Acked-by: Alex Williamson <address@hidden>
>
> Thanks. Any guess at when your vGPU series will be pushed? Mine will
> conflict until that is merged upstream.
It's been out long enough, I'll send a pull request tomorrow. Thanks,
Alex
- [Qemu-devel] [PATCHv3 0/7] Allow EEH on spapr-pci-host-bridge devices, David Gibson, 2016/03/07
- [Qemu-devel] [PATCHv3 4/7] spapr_pci: Allow EEH on spapr-pci-host-bridge, David Gibson, 2016/03/07
- [Qemu-devel] [PATCHv3 3/7] spapr_pci: Eliminate class callbacks, David Gibson, 2016/03/07
- [Qemu-devel] [PATCHv3 7/7] vfio: Eliminate vfio_container_ioctl(), David Gibson, 2016/03/07
- [Qemu-devel] [PATCHv3 5/7] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge, David Gibson, 2016/03/07
- [Qemu-devel] [PATCHv3 6/7] spapr_pci: Remove finish_realize hook, David Gibson, 2016/03/07