[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support

From: Jason Wang
Subject: Re: [Qemu-devel] [PATCHv9 03/10] slirp: Adding IPv6 UDP support
Date: Tue, 8 Mar 2016 09:40:28 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 03/07/2016 07:36 PM, Samuel Thibault wrote:
> Jason Wang, on Mon 07 Mar 2016 14:57:11 +0800, wrote:
>> Part of the codes looks duplicated with ipv4 version. Any chances to
>> merge them like tcp?
> The duplication is actually quite small: accessing the ip length
> is different, filling the address is different, etc.  So there are
> differences all along the code.  Is it really worth the factorization?
> It seems to me that it would actually *reduce* lisibility.
> Samuel

I see, so it's ok to leave this patch as is.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]