[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] qemu AIO worker threads change causes Guest OS hangup |
Date: |
Mon, 7 Mar 2016 14:02:13 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 06/03/2016 03:42, Huaicheng Li (coperd) wrote:
>
>> On Mar 1, 2016, at 3:01 PM, Paolo Bonzini <address@hidden
>> <mailto:address@hidden>> wrote:
>>
>> This is done
>> because the worker threads only care about the queued request list, not
>> about active or completed requests.
>
> Do you think it would be useful to add an API for inserting one request
> back
> to the queued list? For example, In case of request failure, we can
> insert it
> back to the list for re-handling according to some rule before returning
> it directly
> to guest os.
Hi,
this is usually handled at a higher level than the thread pool. See for
example hw/block/virtio-blk.c's restart mechanism, which is enabled with
the rerror=stop and werror=stop options of -drive.
Paolo