qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP


From: Samuel Thibault
Subject: Re: [Qemu-devel] [PATCHv9 01/10] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration
Date: Mon, 7 Mar 2016 12:24:28 +0100
User-agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30)

Jason Wang, on Mon 07 Mar 2016 14:53:54 +0800, wrote:
> > +    switch (ip6->ip_nh) {
> > +#if 0
> > +    case IPPROTO_TCP:
> > +        tcp_input(m, hlen, (struct socket *)NULL);
> > +        break;
> > +    case IPPROTO_UDP:
> > +        udp_input(m, hlen);
> > +        break;
> > +#endif
> 
> This looks odd, why need this?

To pave the way for the patches after that. We can drop that from this
patch and move to the other ones if you will, I just believe it makes
reading this one easier since it explains how tcp and udp will be
plugged here.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]