Re: [Qemu-devel] [Qemu-arm] [PATCH] Fix bug: SRS instructions would trap to EL3 in Secure EL1 even if specified mode was not monitor mode.

[Sergey Fedorov]

On 07.03.2016 00:14, Peter Maydell wrote:
> On 7 March 2016 at 02:04, Sergey Fedorov <address@hidden> wrote:
> > On 23.02.2016 01:25, Ralf-Philipp Weinmann wrote:
> > > According to the ARMv8 Architecture reference manual [F6.1.203], ALL
> > > of the following conditions need to be met for SRS to trap to EL3:
> > > * It is executed at Secure PL1.
> > > * The specified mode is monitor mode.
> > > * EL3 is using AArch64.
> >
> > The code changes in the patch looks good for me. But anyway, you should:
> >   (1) tweak the commit message title according to the requirements [1] and
> >   (2) add your "Singed-off-by:" line [2]
> Ralf-Philipp sent a second version of this email which did
> have the signed-off-by line, so this patch is already in
> master (as commit ba63cf47a9304113); I did tweak the
> commit message as I applied it.

Really, not sure how I missed that :)

Regards,
Sergey