Re: [Qemu-devel] [PATCH v5 3/5] nvdimm acpi: let qemu handle _DSM method

[Xiao Guangrong]

On 03/03/2016 09:23 PM, Michael S. Tsirkin wrote:

> > +     *
> > +     * They are RAM mapping on host so that these accesses never cause
> > +     * VM-EXIT.
> > +     */
> > +    field = aml_field("NRAM", AML_DWORD_ACC, AML_NOLOCK, AML_PRESERVE);
> > +    aml_append(field, aml_named_field("HDLE",
> > +               sizeof(typeof_field(NvdimmDsmIn, handle)) * BITS_PER_BYTE));
> > +    aml_append(field, aml_named_field("REVS",
> > +               sizeof(typeof_field(NvdimmDsmIn, revision)) * BITS_PER_BYTE));
> > +    aml_append(field, aml_named_field("FUNC",
> > +               sizeof(typeof_field(NvdimmDsmIn, function)) * BITS_PER_BYTE));
> > +    aml_append(field, aml_named_field("ARG3",
> > +               (TARGET_PAGE_SIZE - offsetof(NvdimmDsmIn, arg3)) *
> > +                     BITS_PER_BYTE));
>
> drop the extra () here please, and align BITS_PER_BYTE with
> TARGET_PAGE_SIZE.

Michael, the () is necessary here, as it is calculating the number of bits:

(PAGE_SIZE - offset_of_arg3) * BITS_PER_BYTE