[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 09/10] chardev: Drop useless ChardevDummy typ

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 09/10] chardev: Drop useless ChardevDummy type
Date: Fri, 04 Mar 2016 15:40:24 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> Commit d0d7708b made ChardevDummy be an empty wrapper type around
> ChardevCommon.  But there is no technical reason for this indirection,
> so simplify the code by directly using the base type.
> Also change the fallback assignment to assign u.null rather than
> u.data, since a future patch will remove the data member of the C
> struct generated for QAPI unions.
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Daniel P. Berrange <address@hidden>

Doesn't compile with MinGW:

qemu/qemu-char.c: In function 'qemu_chr_open_win_con':
qemu/qemu-char.c:2186:29: warning: implicit declaration of function 
'qapi_ChardevDummy_base' [-Wimplicit-function-declaration]
     ChardevCommon *common = qapi_ChardevDummy_base(backend->u.console);
qemu/qemu-char.c:2186:5: warning: nested extern declaration of 
'qapi_ChardevDummy_base' [-Wnested-externs]
     ChardevCommon *common = qapi_ChardevDummy_base(backend->u.console);
qemu/qemu-char.c:2186:29: warning: initialization makes pointer from integer 
without a cast [-Wint-conversion]
     ChardevCommon *common = qapi_ChardevDummy_base(backend->u.console);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]