[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 18/19] qapi: Use anonymous base in CpuInfo
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 18/19] qapi: Use anonymous base in CpuInfo |
|
Date: |
Fri, 4 Mar 2016 07:35:28 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 03/03/2016 06:08 AM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
>
>> Now that the generator supports it, we might as well use an
>> anonymous base rather than breaking out a single-use CpuInfoBase
>> structure.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>
> Again, introspection value remains the same.
>
> Patch looks good.
>
> Should we eliminate more base types?
At this point, we only have one other: BlockdevOptions. Yes, I'll add
it to the list of cleanups. I also have patches posted in the "subset
F" series that converts 'netdev_add' to be introspectible, and which
also uses the anonymous base.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature