Re: [Qemu-devel] [PATCH 38/38] contrib/ivshmem-server: Print "not for production" warning

[Marc-André Lureau]

Hi

On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster <address@hidden> wrote:
> The code is okay for illustrating how things work and for testing, but
> its error handling make it unfit for production use.  Print a warning
> to protect the innocent.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

I guess David would do something about the problems you report. Tbh, I
don't think ivshmem-server is so bad wrt error handling.

Meanwhile:
Reviewed-by: Marc-André Lureau <address@hidden>

>  contrib/ivshmem-server/main.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/contrib/ivshmem-server/main.c b/contrib/ivshmem-server/main.c
> index cca1061..97488dc 100644
> --- a/contrib/ivshmem-server/main.c
> +++ b/contrib/ivshmem-server/main.c
> @@ -197,6 +197,12 @@ main(int argc, char *argv[])
>      };
>      int ret = 1;
>
> +    /*
> +     * Do not remove this notice without adding proper error handling!
> +     * Start with handling ivshmem_server_send_one_msg() failure.
> +     */
> +    printf("*** Example code, do not use in production ***\n");
> +
>      /* parse arguments, will exit on error */
>      ivshmem_server_parse_args(&args, argc, argv);
>
> --
> 2.4.3
>
>



-- 
Marc-André Lureau