Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit

[Peter Maydell]

On 2 March 2016 at 17:13, Programmingkid <address@hidden> wrote:
>
> On Mar 2, 2016, at 11:45 AM, Peter Maydell wrote:
>
>> On 2 March 2016 at 15:55, Markus Armbruster <address@hidden> wrote:
>>> I'd call it mac-keys.h.  mackeys.h would be okay.  There's enough
>>> precedence for '_' in file names to justify mac_keys.h, but I personally
>>> dislike that.
>>
>> Calling it adb-keys.h would make it clearer that what we're defining
>> here are the scancodes for ADB keyboards. (They happen to be the
>> same as the Cocoa/Carbon GUI keycodes for modern macs with non
>> ADB keyboards, but this is just a historical effect.)
>
> Did you want me to change all the constants to something other than MAC_KEY_ ?
> I could be ADB_KEY_ for all the keys if you want.

Yes, I think if we're calling it adb-keys.h then a search-and-replace
on the constant names to match would be a good idea.

-- PMM