Re: [Qemu-devel] [PATCH v2 4/4] rng: add request queue support to rng-random

[Amit Shah]

On (Wed) 10 Feb 2016 [16:53:25], Ladi Prosek wrote:
> Requests are now created in the RngBackend parent class and the
> code path is shared by both rng-egd and rng-random.
> 
> This commit fixes the rng-random implementation which currently
> processes only one request at a time and simply discards all
> but the most recent one. In the guest this manifests as delayed
> completion of reads from virtio-rng, i.e. a read is completed
> only after another read is issued.

Nice commit message, but one convention I like is: when you're fixing
something, refer to the bug in past tense, so it's not confusing with
existing behaviour (i.e. since you're already fixing that bug in this
patch, it's better to write in the past tense about this bug).

Also, since you mentioned the move from stack-based allocation to
heap-based in the cover letter, and since this patch actually does
that, please include a one-liner here for it too.

Otherwise, the series is fine.

                Amit