qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 5/9] qemu-log: new option -dfilter to limit o


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v7 5/9] qemu-log: new option -dfilter to limit output
Date: Fri, 26 Feb 2016 12:25:50 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

On 02/22/2016 07:59 AM, Alex Bennée wrote:
> +    qemu_set_dfilter_ranges("0x1000+0x100");
> +
> +    g_assert_false(qemu_log_in_addr_range(0xfff));
> +    g_assert(qemu_log_in_addr_range(0x1000));
> +    g_assert(qemu_log_in_addr_range(0x1100));

This is exactly what I was talking about wrt off-by-one error in my first
review -- 0x100 bytes, including 0x1000, finishes at 0x10ff.

This third test should fail.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]