Re: [Qemu-devel] [PATCH 1/2] virtio-balloon: export all balloon statistics

[Roman Kagan]

On Thu, Feb 25, 2016 at 03:10:09PM +0100, Markus Armbruster wrote:
> Roman Kagan <address@hidden> writes:
> Now I'm confused.  According to virtio-balloon-stats.txt, they're
> exposed as virtio-balloon properties in QOM.  I don't understand how
> these are related to query-balloon, nor what a new monitor command
> query-balloon-raw would be good for.

Oops, sorry, you're right, I mixed it all up: query-balloon only reports
how big the balloon is currently inflated, while the stats are indeed
exposed as object properties.  So query-balloon-raw makes no sense.

> You seem to propose adding stats unknown to QEMU with numeric names.  If
> there's an authority mapping numbers to meaning, the numbers so mapped
> would be suitable as stable interface.  However, for the numbers QEMU
> knows to be mapped, it surely knows names, too, so limiting the thing to
> such numbers would be pointless.
> 
> The only way you can make numbers QEMU doesn't know a stable interface
> is declaring the interface a mere transport between guest and management
> application.

But that's what it currently is.

Roman.