[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 2/3] qmp event: Refactor QUORUM_REPORT_BAD |
|
Date: |
Wed, 24 Feb 2016 18:12:05 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 02/24/2016 05:50 PM, Wen Congyang wrote:
>>> +- "type": Quorum operation type (json-string, optional)
>>
>> I don't think 'type' needs to be optional, after all. Just always
>> output it.
>
> If we output read/write type, old libvirt will ignore the read/write error
> events?
The QMP protocol already documents that ALL clients MUST ignore
unexpected output fields. Any client that is unprepared for new fields
appearing in the dictionary is buggy. Libvirt will be just fine if you
output a new "type":"read".
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v5 3/3] quorum: modify vote rules for flush operation, (continued)