[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 07/23] balloon: Use only 'pc-dimm' type dimm for ball
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 07/23] balloon: Use only 'pc-dimm' type dimm for ballooning |
Date: |
Wed, 24 Feb 2016 22:35:28 +0200 |
From: Vladimir Sementsov-Ogievskiy <address@hidden>
For now there are only two dimm's: pc-dimm and nvdimm. This patch is
actually needed to disable ballooning on nvdimm. But, to avoid future
bugs, instead of disallowing nvdimm, we allow only pc-dimm. So, if
someone adds new dimm which should be balloon-able, then this ability
should be explicitly specified here.
Why ballooning for nvdimm should be disabled for now:
NVDIMM for now is planned to use as a backing store for DAX filesystem
in the guest and thus this memory is excluded from guest memory
management and LRUs.
In this case libvirt running QEMU along with configured balloon almost
immediately inflates balloon and effectively kill the guest as
qemu counts nvdimm as part of the ram.
Counting dimm devices as part of the ram for ballooning was started from
commit 463756d03:
virtio-balloon: Fix balloon not working correctly when hotplug memory
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/virtio/virtio-balloon.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 388e873..3fb6c52 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -313,7 +313,10 @@ static ram_addr_t get_current_ram_size(void)
pc_dimm_build_list(qdev_get_machine(), &list);
for (item = list; item; item = g_slist_next(item)) {
Object *obj = OBJECT(item->data);
- size += object_property_get_int(obj, PC_DIMM_SIZE_PROP, &error_abort);
+ if (!strcmp(object_get_typename(obj), TYPE_PC_DIMM)) {
+ size += object_property_get_int(obj, PC_DIMM_SIZE_PROP,
+ &error_abort);
+ }
}
g_slist_free(list);
--
MST
- [Qemu-devel] [PULL 00/23] vhost, virtio, pci, pc, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 02/23] vhost-user: don't merge regions with different fds, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 01/23] bios-linker-loader: document+validate input, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 03/23] move get_current_ram_size to virtio-balloon.c, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 04/23] pc-dimm: rename pc_dimm_built_list(), Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 05/23] pc-dimm: add pc_dimm_build_list(), Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 06/23] virtio-balloon: rewrite get_current_ram_size(), Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 07/23] balloon: Use only 'pc-dimm' type dimm for ballooning,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 08/23] pci core: function pci_host_bus_register() cleanup, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 09/23] pci core: function pci_bus_init() cleanup, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 10/23] block-migration: acquire AioContext as necessary, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 11/23] vring: make vring_enable_notification return void, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 12/23] virtio: add AioContext-specific function for host notifiers, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 13/23] virtio: export vring_notify as virtio_should_notify, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 14/23] virtio-blk: fix "disabled data plane" mode, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 16/23] virtio-scsi: do not use vring in dataplane, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 15/23] virtio-blk: do not use vring in dataplane, Michael S. Tsirkin, 2016/02/24
- [Qemu-devel] [PULL 17/23] vring: remove, Michael S. Tsirkin, 2016/02/24