[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/2] net: minor indentation updates
From: |
P J P |
Subject: |
[Qemu-devel] [PATCH v2 2/2] net: minor indentation updates |
Date: |
Tue, 23 Feb 2016 21:38:27 +0530 |
From: Prasad J Pandit <address@hidden>
Due indentation and braces were missing at places, added them.
Signed-off-by: Prasad J Pandit <address@hidden>
---
net/checksum.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
Update as per review:
-> https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg03799.html
diff --git a/net/checksum.c b/net/checksum.c
index bd89083..c3f1f71 100644
--- a/net/checksum.c
+++ b/net/checksum.c
@@ -38,8 +38,9 @@ uint32_t net_checksum_add_cont(int len, uint8_t *buf, int seq)
uint16_t net_checksum_finish(uint32_t sum)
{
- while (sum>>16)
- sum = (sum & 0xFFFF)+(sum >> 16);
+ while (sum >> 16) {
+ sum = (sum & 0xFFFF) + (sum >> 16);
+ }
return ~sum;
}
@@ -63,22 +64,23 @@ void net_checksum_calculate(uint8_t *data, int length)
if (length < 14 + 20) {
return;
}
+ if ((data[14] & 0xf0) != 0x40) {
+ return; /* not IPv4 */
+ }
- if ((data[14] & 0xf0) != 0x40)
- return; /* not IPv4 */
hlen = (data[14] & 0x0f) * 4;
plen = (data[16] << 8 | data[17]) - hlen;
proto = data[23];
switch (proto) {
case PROTO_TCP:
- csum_offset = 16;
- break;
+ csum_offset = 16;
+ break;
case PROTO_UDP:
- csum_offset = 6;
- break;
+ csum_offset = 6;
+ break;
default:
- return;
+ return;
}
if (plen < csum_offset + 2 || plen + hlen >= length) {
--
2.5.0