Re: [Qemu-devel] [PATCH v2 1/1] quorum: Change vote rules for 64 bits hash

[Alberto Garcia]

On Mon 22 Feb 2016 02:31:30 PM CET, Alberto Garcia wrote:
>> Anyway, regardless of that, if we do take the threshold into account,
>> we should not use the exact error value for voting but just whether
>> an error occurred or not. If all but one children fail to flush (all
>> for different reasons), I find it totally wrong to return success. We
>> should then just return -EIO or something.
>
> Exactly. I think -EIO should be fine, I'm not sure why it was proposed
> to vote the return code in this case?

I correct myself: when reads or writes fail we also vote the return
code. We only return -EIO when there are few or no I/O errors but the
results differ and we cannot get a majority that reaches the threshold.

Berto