qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010
Date: Mon, 22 Feb 2016 09:18:35 +0000

On 22 February 2016 at 03:15, xiaoqiang zhao <address@hidden> wrote:
> Move majority of old SysBus init's work the into instance_init.
>
> Note:
> musb_init must be called in SysBus's init, otherwise it will
> break "make check" with error message as follows:
>
> qom/object.c:1576:object_get_canonical_path_component: assertion failed: 
> (obj->parent != NULL)
>
> Signed-off-by: xiaoqiang zhao <address@hidden>
> ---
>  hw/timer/tusb6010.c | 23 ++++++++++++++++-------
>  1 file changed, 16 insertions(+), 7 deletions(-)

Devices should either be instance_init + realize, or
sysbus-init. This patch would make this device be a mix
of both. You should just drop this patch until musb has
been properly QOMified.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]