Re: [Qemu-devel] [PATCH 2/2] trace: separate MMIO tracepoints from TB-access tracepoints

[Hollis Blanchard]

On 02/17/2016 01:29 PM, Hollis Blanchard wrote:
> diff --git a/trace-events b/trace-events
> index 756ce86..7994420 100644
> --- a/trace-events
> +++ b/trace-events
> @@ -1630,6 +1630,8 @@ memory_region_ops_read(int cpu_index, void *mr, uint64_t 
> addr, uint64_t value, u
>   memory_region_ops_write(int cpu_index, void *mr, uint64_t addr, uint64_t value, unsigned size) "cpu %d 
> mr %p addr %#"PRIx64" value %#"PRIx64" size %u"
>   memory_region_subpage_read(int cpu_index, void *mr, uint64_t offset, uint64_t value, unsigned size) 
> "cpu %d mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
>   memory_region_subpage_write(int cpu_index, void *mr, uint64_t offset, uint64_t value, unsigned size) 
> "cpu %d mr %p offset %#"PRIx64" value %#"PRIx64" size %u"
> +memory_region_ops_tb_read(int cpu_index, uint64_t addr, uint64_t value, unsigned size) "cpu %d addr 
> %#"PRIx64" value %#"PRIx64" size %u"
> +memory_region_ops_tb_write(int cpu_index, uint64_t addr, uint64_t value, unsigned size) "cpu %d addr 
> %#"PRIx64" value %#"PRIx64" size %u"

Actually, I'd like to rename these new tracepoints to 
"memory_region_tb_read/write", for consistency with 
"memory_region_subpage_read/write". I'll wait for other comments before 
re-submitting though.

Hollis Blanchard
Mentor Graphics Emulation Division