Re: [Qemu-devel] [PATCH] target-mips: Stop using uint_fast*_t types in r4k_tlb_t struct

[Peter Maydell]

On 2 February 2016 at 10:49, Leon Alrae <address@hidden> wrote:
> On 25/01/16 17:40, Peter Maydell wrote:
>> The r4k_tlb_t structure uses the uint_fast*_t types. Most of these
>> uses are in bitfields and are thus pointless, because the bitfield
>> itself specifies the width of the type; just use 'unsigned int'
>> instead. (On glibc uint_fast16_t is defined as either 32 or 64 bits,
>> so we know the code is not reliant on it being exactly 16 bits.)
>> There is also one use of uint_fast8_t, which we replace with uint8_t,
>> because both are exactly 8 bits on glibc and this is the only
>> place outside the softfloat code which uses an int_fast*_t type.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> I'm going to have a go at getting rid of the int_fast16_t usage
>> in the softfloat code too, but in the meantime this is an
>> independent cleanup.
>>
>>  target-mips/cpu.h | 26 +++++++++++++-------------
>>  1 file changed, 13 insertions(+), 13 deletions(-)
>
> Applied to target-mips tree, thanks.

Hi -- is this going to appear in master soon? I have another patch
pending that depends on it...

thanks
-- PMM