[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 00/10] Make qemu-img/qemu-nbd/qemu-io CLI mor
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v6 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible |
Date: |
Wed, 17 Feb 2016 10:41:49 +0000 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Feb 17, 2016 at 11:37:52AM +0100, Kevin Wolf wrote:
> Am 17.02.2016 um 11:10 hat Daniel P. Berrange geschrieben:
> > On Mon, Feb 15, 2016 at 04:53:27PM +0100, Kevin Wolf wrote:
> > > Am 15.02.2016 um 15:33 hat Daniel P. Berrange geschrieben:
> > > > This series of patches expands the syntax of the qemu-img,
> > > > qemu-nbd and qemu-io commands to make them more flexible.
> > > >
> > > > v0:
> > > > https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html
> > > > v1:
> > > > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04014.html
> > > > v2:
> > > > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04354.html
> > > > v3:
> > > > https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg03381.html
> > > > v4:
> > > > https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg04984.html
> > > > v5:
> > > > https://lists.gnu.org/archive/html/qemu-block/2016-02/msg00022.html
> > > >
> > > > First all three gain a --object parameter, which allows
> > > > instantiation of user creatable object types. The immediate
> > > > use case is to allow for creation of the 'secret' object
> > > > type to pass passwords for curl, iscsi and rbd drivers.
> > > > For qemu-nbd this will also be needed to create TLS
> > > > certificates for encryption support.
> > > >
> > > > Then all three gain a '--image-opts' parameter which causes
> > > > the positional filenames to be interepreted as option strings
> > > > rather tha nplain filenames. This avoids the need to use the
> > > > JSON syntax, or to add custom CLI args for each block backend
> > > > option that exists. The immediate use case is to allow the
> > > > user to specify the ID of the 'secret' object they just created.
> > > >
> > > > Finally, there are a few small cleanup patches
> > >
> > > Thanks, applied to the block branch.
> >
> > The NBD patches just merged, so I've rebased this series and sent you
> > a v7 to resolve the conflicts
>
> *sigh* Okay, I'll drop this series and re-review sometime later.
NB it was a pretty clear rebase with no functional changes. Mostly
just resolving conflicts in the "struct option" list entries used
for getopt_long
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v6 03/10] qemu-nbd: add support for --object command line arg, (continued)
- [Qemu-devel] [PATCH v6 03/10] qemu-nbd: add support for --object command line arg, Daniel P. Berrange, 2016/02/15
- [Qemu-devel] [PATCH v6 09/10] qemu-nbd: use no_argument/required_argument constants, Daniel P. Berrange, 2016/02/15
- [Qemu-devel] [PATCH v6 01/10] qom: add helpers for UserCreatable object types, Daniel P. Berrange, 2016/02/15
- [Qemu-devel] [PATCH v6 08/10] qemu-nbd: don't overlap long option values with short options, Daniel P. Berrange, 2016/02/15
- [Qemu-devel] [PATCH v6 07/10] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2016/02/15
- [Qemu-devel] [PATCH v6 10/10] qemu-io: use no_argument/required_argument constants, Daniel P. Berrange, 2016/02/15
- [Qemu-devel] [PATCH v6 05/10] qemu-io: allow specifying image as a set of options args, Daniel P. Berrange, 2016/02/15
- Re: [Qemu-devel] [PATCH v6 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible, Kevin Wolf, 2016/02/15