[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv7 1/9] slirp: Adding IPv6, ICMPv6 Echo and NDP a
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCHv7 1/9] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration |
Date: |
Tue, 16 Feb 2016 12:36:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 14.02.2016 18:47, Samuel Thibault wrote:
> From: Guillaume Subiron <address@hidden>
>
> This patch adds the functions needed to handle IPv6 packets. ICMPv6 and
> NDP headers are implemented.
>
> Slirp is now able to send NDP Router or Neighbor Advertisement when it
> receives Router or Neighbor Solicitation. Using a 64bit-sized IPv6
> prefix, the guest is now able to perform stateless autoconfiguration
> (SLAAC) and to compute its IPv6 address.
>
> This patch adds an ndp_table, mainly inspired by arp_table, to keep an
> NDP cache and manage network address resolution.
> Slirp regularly sends NDP Neighbor Advertisement, as recommended by the
> RFC, to make the guest refresh its route.
>
> This also adds ip6_cksum() to compute ICMPv6 checksums using IPv6
> pseudo-header.
>
> Some #define ETH_* are moved upper in slirp.h to make them accessible to
> other slirp/*.h
>
> Signed-off-by: Guillaume Subiron <address@hidden>
> Signed-off-by: Samuel Thibault <address@hidden>
> ---
> slirp/Makefile.objs | 6 +-
> slirp/cksum.c | 25 ++++
> slirp/if.c | 2 +-
> slirp/ip6.h | 135 ++++++++++++++++++++
> slirp/ip6_icmp.c | 347
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
> slirp/ip6_icmp.h | 203 ++++++++++++++++++++++++++++++
> slirp/ip6_input.c | 69 +++++++++++
> slirp/ip6_output.c | 38 ++++++
> slirp/ndp_table.c | 84 +++++++++++++
> slirp/slirp.c | 49 +++++++-
> slirp/slirp.h | 37 ++++++
> slirp/socket.h | 7 ++
> 12 files changed, 996 insertions(+), 6 deletions(-)
> create mode 100644 slirp/ip6.h
> create mode 100644 slirp/ip6_icmp.c
> create mode 100644 slirp/ip6_icmp.h
> create mode 100644 slirp/ip6_input.c
> create mode 100644 slirp/ip6_output.c
> create mode 100644 slirp/ndp_table.c
Patch looks fine to me now.
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCHv8 0/9] slirp: Adding IPv6 support to Qemu -net user mode, Samuel Thibault, 2016/02/14
- [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support, Samuel Thibault, 2016/02/14
- [Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring, Samuel Thibault, 2016/02/14
- [Qemu-devel] [PATCHv7 2/9] slirp: Adding ICMPv6 error sending, Samuel Thibault, 2016/02/14
- [Qemu-devel] [PATCHv7 5/9] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff, Samuel Thibault, 2016/02/14
- [Qemu-devel] [PATCHv7 1/9] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration, Samuel Thibault, 2016/02/14
- [Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union, Samuel Thibault, 2016/02/14
[Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions, Samuel Thibault, 2016/02/14