[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/12] docker: Add basic test
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 06/12] docker: Add basic test |
Date: |
Mon, 15 Feb 2016 14:52:23 +0000 |
User-agent: |
mu4e 0.9.17; emacs 25.0.91.2 |
Peter Maydell <address@hidden> writes:
> On 15 February 2016 at 14:34, Alex Bennée <address@hidden> wrote:
>>
>> Fam Zheng <address@hidden> writes:
>>> +cd $(mktemp -d)
>>> +mkdir build
>>> +mkdir install
>>> +cd build
>>> +build_qemu --target-list=x86_64-softmmu --prefix="${pwd}/install"
>
> Why restrict the target list ?
>
>>> +make check $MAKEFLAGS
>>> +make install
>>
>> From my excursions last week into the tests directory I discovered the
>> unit tests are built for a number of different qtest binaries. For
>> completeness we should probably include the whole list:
>>
>> #+name: qtest-targets
>> #+begin_src sh :dir ~/lsrc/qemu/qemu.git :results scalar
>> grep -E "check-qtest-[[:alnum:]]+-y " tests/Makefile | cut -d " " -f 1 |
>> sort -u
>> #+end_src
>>
>> #+RESULTS: qtest-targets
>> #+begin_example
>> check-qtest-arm-y
>> check-qtest-generic-y
>> check-qtest-i386-y
>> check-qtest-ipack-y
>> check-qtest-microblazeel-y
>> check-qtest-mips64el-y
>> check-qtest-mips64-y
>> check-qtest-mips-y
>> check-qtest-pci-y
>> check-qtest-ppc64-y
>> check-qtest-ppc-y
>> check-qtest-sh4eb-y
>> check-qtest-sh4-y
>> #check-qtest-sparc64-y
>> check-qtest-sparc64-y
>> #check-qtest-sparc-y
>> check-qtest-virtioserial-y
>> check-qtest-virtio-y
>> check-qtest-x86_64-y
>> check-qtest-xtensaeb-y
>> check-qtest-y
>> #+end_example
>
> I'm having difficulty figuring out what you're proposing here,
> but it looks like you're suggesting listing all the check-qtest-*
> test names again here, which seems worth avoiding. We should
> just do a build and make check and let that take care of
> running all the tests.
Well there is a halfway house between building one target and building
all possible targets. Not all the softmmu targets include additional
tests. Having said that it is probably simpler as you say to just build
everything.
>
> thanks
> -- PMM
--
Alex Bennée
- [Qemu-devel] [PATCH 04/12] docker: Add test runner, (continued)
[Qemu-devel] [PATCH 05/12] docker: Add common.rc, Fam Zheng, 2016/02/05
[Qemu-devel] [PATCH 06/12] docker: Add basic test, Fam Zheng, 2016/02/05
[Qemu-devel] [PATCH 07/12] docker: Add clang test, Fam Zheng, 2016/02/05
[Qemu-devel] [PATCH 08/12] docker: Add mingw test, Fam Zheng, 2016/02/05
[Qemu-devel] [PATCH 09/12] docker: Add travis tool, Fam Zheng, 2016/02/05
[Qemu-devel] [PATCH 10/12] docs: Add text for tests/docker in build-system.txt, Fam Zheng, 2016/02/05
[Qemu-devel] [PATCH 11/12] .gitignore: Ignore temporary dockerfile, Fam Zheng, 2016/02/05
[Qemu-devel] [PATCH 12/12] MAINTAINERS: Add tests/docker, Fam Zheng, 2016/02/05