[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size conf
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size configurable |
Date: |
Sun, 14 Feb 2016 14:46:13 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, 02/12 18:06, John Snow wrote:
> typedef struct CowRequest {
> @@ -46,6 +43,8 @@ typedef struct BackupBlockJob {
> CoRwlock flush_rwlock;
> uint64_t sectors_read;
> HBitmap *bitmap;
> + int64_t cluster_size;
> + int64_t sectors_per_cluster;
I don't think it makes sense to duplicate one value in two units.
Fam