[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCHv7 6/9] slirp: Reindent after refactoring |
Date: |
Thu, 11 Feb 2016 10:56:30 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 02/10/2016 02:20 AM, Samuel Thibault wrote:
> Thomas Huth, on Wed 10 Feb 2016 09:42:04 +0100, wrote:
>> On 08.02.2016 11:28, Samuel Thibault wrote:
>>> Signed-off-by: Guillaume Subiron <address@hidden>
>>> Signed-off-by: Samuel Thibault <address@hidden>
>>> ---
>>> slirp/tcp_input.c | 99
>>> +++++++++++++++++++++++++++---------------------------
>>> slirp/tcp_output.c | 29 ++++++++--------
>>> slirp/tcp_subr.c | 50 +++++++++++++--------------
>>> 3 files changed, 89 insertions(+), 89 deletions(-)
>>
>> Not sure, it's just an idea, but maybe it would even make sense to
>> re-indent the whole files in the QEMU coding style now? I mean, indent
>> with 4 spaces instead of tabs?
>
> I'm fine with doing it. Maintainers, what do you think?
If done as part of the series, it's probably okay to do it as a
pre-requisite patch. Don't mix it in with actual code changes, and we
don't do whole-sale reindenting except as part of a larger series
(because 'git blame' will point to whoever did the reindenting instead
of the original code, which doesn't make sense when reindenting is done
in isolation).
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCHv7 4/9] slirp: Factorizing tcpiphdr structure with an union, Samuel Thibault, 2016/02/08
[Qemu-devel] [PATCHv7 8/9] slirp: Adding IPv6 address for DNS relay, Samuel Thibault, 2016/02/08
[Qemu-devel] [PATCHv7 7/9] slirp: Handle IPv6 in TCP functions, Samuel Thibault, 2016/02/08