Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support

[Samuel Thibault]

Thomas Huth, on Tue 09 Feb 2016 21:44:18 +0100, wrote:
> > +       case AF_INET6:
> > +           udp6_output(so, m, (struct sockaddr_in6 *) &saddr,
> > +                       (struct sockaddr_in6 *) &daddr);
> > +           break;
> >         default:
> > +           g_assert_not_reached();
> 
> Could this be triggered by the guest?

No, here we are in sorecvfrom, which only reads ipv4 or ipv6 packets
from the udp socket.

> > +    so->so_ffamily = AF_INET6;
> > +    so->so_faddr6 = ip->ip_dst; /* XXX */
> > +    so->so_fport6 = uh->uh_dport; /* XXX */
> 
> Why use the XXXs here? Some additional words in the comments would be
> nice...

That's a copy/paste from the UDPv4 code.  I don't know why they are there.

Samuel