qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 05/13] trace: split trace_init_file out of trace_


From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PULL 05/13] trace: split trace_init_file out of trace_init_backends
Date: Tue, 9 Feb 2016 22:19:47 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 02/09/2016 03:28 PM, Alex Bennée wrote:
Denis V. Lunev <address@hidden> writes:

On 02/08/2016 09:43 PM, Alex Bennée wrote:
Stefan Hajnoczi <address@hidden> writes:

From: Paolo Bonzini <address@hidden>

This is cleaner, and improves error reporting with -daemonize.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
Acked-by: Christian Borntraeger <address@hidden>
Message-id: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
   qemu-io.c       |  2 +-
   trace/control.c | 17 ++++++++++++-----
   trace/control.h | 13 ++++++++++++-
   trace/simple.c  |  6 ++----
   trace/simple.h  |  4 ++--
   vl.c            | 13 +++++++++----
   6 files changed, 38 insertions(+), 17 deletions(-)

diff --git a/qemu-io.c b/qemu-io.c
index 1c11d57..83c48f4 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -435,7 +435,7 @@ int main(int argc, char **argv)
               }
               break;
           case 'T':
-            if (!trace_init_backends(optarg)) {
+            if (!trace_init_backends()) {
                   exit(1); /* error message will have been printed */
               }
               break;
diff --git a/trace/control.c b/trace/control.c
index 931d64c..f5a497a 100644
--- a/trace/control.c
+++ b/trace/control.c
@@ -145,17 +145,24 @@ void trace_init_events(const char *fname)
       loc_pop(&loc);
   }

-bool trace_init_backends(const char *file)
+void trace_init_file(const char *file)
   {
   #ifdef CONFIG_TRACE_SIMPLE
-    if (!st_init(file)) {
-        fprintf(stderr, "failed to initialize simple tracing backend.\n");
-        return false;
-    }
+    st_set_trace_file(file);
This breaks "make check" as st_set_trace_file will attempt to flush the
file:
this does not hang for me even with CONFIG_TRACE_SIMPLE enabled.
Could you share your ./configure options?
./configure --target-list=x86_64-softmmu --enable-trace-backends=simple

Also see:

https://travis-ci.org/stsquad/qemu/jobs/107280320

--
Alex Bennée
for the reference (proposed fix):

http://lists.nongnu.org/archive/html/qemu-devel/2016-02/msg02123.html



reply via email to

[Prev in Thread] Current Thread [Next in Thread]