[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/31] qapi: Avoid use of misnamed DO_UPCAST()
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 06/31] qapi: Avoid use of misnamed DO_UPCAST() |
Date: |
Tue, 9 Feb 2016 12:37:38 +0100 |
From: Eric Blake <address@hidden>
The macro DO_UPCAST() is incorrectly named: it converts from a
parent class to a derived class (which is a downcast). Better,
and more consistent with some of the other qapi visitors, is
to use the container_of() macro through a to_FOO() helper. Names
like 'to_ov()' may be a bit short, but for a static helper it
doesn't hurt too much, and matches existing practice in files
like qmp-input-visitor.c.
Our current definition of container_of() is weaker than
DO_UPCAST(), in that it does not require the derived class to
have Visitor as its first member, but this does not hurt our
usage patterns in qapi visitors.
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
qapi/opts-visitor.c | 28 +++++++++++++++++-----------
qapi/string-input-visitor.c | 23 ++++++++++++++---------
qapi/string-output-visitor.c | 21 +++++++++++++--------
3 files changed, 44 insertions(+), 28 deletions(-)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index eb7d85b..4955ac8 100644
--- a/qapi/opts-visitor.c
+++ b/qapi/opts-visitor.c
@@ -90,6 +90,12 @@ struct OptsVisitor
};
+static OptsVisitor *to_ov(Visitor *v)
+{
+ return container_of(v, OptsVisitor, visitor);
+}
+
+
static void
destroy_list(gpointer list)
{
@@ -122,7 +128,7 @@ static void
opts_start_struct(Visitor *v, void **obj, const char *kind,
const char *name, size_t size, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
const QemuOpt *opt;
if (obj) {
@@ -161,7 +167,7 @@ ghr_true(gpointer ign_key, gpointer ign_value, gpointer
ign_user_data)
static void
opts_end_struct(Visitor *v, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
GQueue *any;
if (--ov->depth > 0) {
@@ -203,7 +209,7 @@ lookup_distinct(const OptsVisitor *ov, const char *name,
Error **errp)
static void
opts_start_list(Visitor *v, const char *name, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
/* we can't traverse a list in a list */
assert(ov->list_mode == LM_NONE);
@@ -217,7 +223,7 @@ opts_start_list(Visitor *v, const char *name, Error **errp)
static GenericList *
opts_next_list(Visitor *v, GenericList **list, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
GenericList **link;
switch (ov->list_mode) {
@@ -266,7 +272,7 @@ opts_next_list(Visitor *v, GenericList **list, Error **errp)
static void
opts_end_list(Visitor *v, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
assert(ov->list_mode == LM_STARTED ||
ov->list_mode == LM_IN_PROGRESS ||
@@ -308,7 +314,7 @@ processed(OptsVisitor *ov, const char *name)
static void
opts_type_str(Visitor *v, char **obj, const char *name, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
const QemuOpt *opt;
opt = lookup_scalar(ov, name, errp);
@@ -324,7 +330,7 @@ opts_type_str(Visitor *v, char **obj, const char *name,
Error **errp)
static void
opts_type_bool(Visitor *v, bool *obj, const char *name, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
const QemuOpt *opt;
opt = lookup_scalar(ov, name, errp);
@@ -357,7 +363,7 @@ opts_type_bool(Visitor *v, bool *obj, const char *name,
Error **errp)
static void
opts_type_int(Visitor *v, int64_t *obj, const char *name, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
const QemuOpt *opt;
const char *str;
long long val;
@@ -413,7 +419,7 @@ opts_type_int(Visitor *v, int64_t *obj, const char *name,
Error **errp)
static void
opts_type_uint64(Visitor *v, uint64_t *obj, const char *name, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
const QemuOpt *opt;
const char *str;
unsigned long long val;
@@ -465,7 +471,7 @@ opts_type_uint64(Visitor *v, uint64_t *obj, const char
*name, Error **errp)
static void
opts_type_size(Visitor *v, uint64_t *obj, const char *name, Error **errp)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
const QemuOpt *opt;
int64_t val;
char *endptr;
@@ -491,7 +497,7 @@ opts_type_size(Visitor *v, uint64_t *obj, const char *name,
Error **errp)
static void
opts_optional(Visitor *v, bool *present, const char *name)
{
- OptsVisitor *ov = DO_UPCAST(OptsVisitor, visitor, v);
+ OptsVisitor *ov = to_ov(v);
/* we only support a single mandatory scalar field in a list node */
assert(ov->list_mode == LM_NONE);
diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
index 8c5ff7e..52db4cf 100644
--- a/qapi/string-input-visitor.c
+++ b/qapi/string-input-visitor.c
@@ -33,6 +33,11 @@ struct StringInputVisitor
const char *string;
};
+static StringInputVisitor *to_siv(Visitor *v)
+{
+ return container_of(v, StringInputVisitor, visitor);
+}
+
static void free_range(void *range, void *dummy)
{
g_free(range);
@@ -121,7 +126,7 @@ error:
static void
start_list(Visitor *v, const char *name, Error **errp)
{
- StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
+ StringInputVisitor *siv = to_siv(v);
parse_str(siv, errp);
@@ -137,7 +142,7 @@ start_list(Visitor *v, const char *name, Error **errp)
static GenericList *
next_list(Visitor *v, GenericList **list, Error **errp)
{
- StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
+ StringInputVisitor *siv = to_siv(v);
GenericList **link;
Range *r;
@@ -176,14 +181,14 @@ next_list(Visitor *v, GenericList **list, Error **errp)
static void
end_list(Visitor *v, Error **errp)
{
- StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
+ StringInputVisitor *siv = to_siv(v);
siv->head = true;
}
static void parse_type_int(Visitor *v, int64_t *obj, const char *name,
Error **errp)
{
- StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
+ StringInputVisitor *siv = to_siv(v);
if (!siv->string) {
error_setg(errp, QERR_INVALID_PARAMETER_TYPE, name ? name : "null",
@@ -225,7 +230,7 @@ error:
static void parse_type_size(Visitor *v, uint64_t *obj, const char *name,
Error **errp)
{
- StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
+ StringInputVisitor *siv = to_siv(v);
Error *err = NULL;
uint64_t val;
@@ -247,7 +252,7 @@ static void parse_type_size(Visitor *v, uint64_t *obj,
const char *name,
static void parse_type_bool(Visitor *v, bool *obj, const char *name,
Error **errp)
{
- StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
+ StringInputVisitor *siv = to_siv(v);
if (siv->string) {
if (!strcasecmp(siv->string, "on") ||
@@ -271,7 +276,7 @@ static void parse_type_bool(Visitor *v, bool *obj, const
char *name,
static void parse_type_str(Visitor *v, char **obj, const char *name,
Error **errp)
{
- StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
+ StringInputVisitor *siv = to_siv(v);
if (siv->string) {
*obj = g_strdup(siv->string);
} else {
@@ -283,7 +288,7 @@ static void parse_type_str(Visitor *v, char **obj, const
char *name,
static void parse_type_number(Visitor *v, double *obj, const char *name,
Error **errp)
{
- StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
+ StringInputVisitor *siv = to_siv(v);
char *endp = (char *) siv->string;
double val;
@@ -302,7 +307,7 @@ static void parse_type_number(Visitor *v, double *obj,
const char *name,
static void parse_optional(Visitor *v, bool *present, const char *name)
{
- StringInputVisitor *siv = DO_UPCAST(StringInputVisitor, visitor, v);
+ StringInputVisitor *siv = to_siv(v);
if (!siv->string) {
*present = false;
diff --git a/qapi/string-output-visitor.c b/qapi/string-output-visitor.c
index b04cec4..b0313cb 100644
--- a/qapi/string-output-visitor.c
+++ b/qapi/string-output-visitor.c
@@ -67,6 +67,11 @@ struct StringOutputVisitor
GList *ranges;
};
+static StringOutputVisitor *to_sov(Visitor *v)
+{
+ return container_of(v, StringOutputVisitor, visitor);
+}
+
static void string_output_set(StringOutputVisitor *sov, char *string)
{
if (sov->string) {
@@ -120,7 +125,7 @@ static void format_string(StringOutputVisitor *sov, Range
*r, bool next,
static void print_type_int(Visitor *v, int64_t *obj, const char *name,
Error **errp)
{
- StringOutputVisitor *sov = DO_UPCAST(StringOutputVisitor, visitor, v);
+ StringOutputVisitor *sov = to_sov(v);
GList *l;
switch (sov->list_mode) {
@@ -196,7 +201,7 @@ static void print_type_int(Visitor *v, int64_t *obj, const
char *name,
static void print_type_size(Visitor *v, uint64_t *obj, const char *name,
Error **errp)
{
- StringOutputVisitor *sov = DO_UPCAST(StringOutputVisitor, visitor, v);
+ StringOutputVisitor *sov = to_sov(v);
static const char suffixes[] = { 'B', 'K', 'M', 'G', 'T', 'P', 'E' };
uint64_t div, val;
char *out;
@@ -227,14 +232,14 @@ static void print_type_size(Visitor *v, uint64_t *obj,
const char *name,
static void print_type_bool(Visitor *v, bool *obj, const char *name,
Error **errp)
{
- StringOutputVisitor *sov = DO_UPCAST(StringOutputVisitor, visitor, v);
+ StringOutputVisitor *sov = to_sov(v);
string_output_set(sov, g_strdup(*obj ? "true" : "false"));
}
static void print_type_str(Visitor *v, char **obj, const char *name,
Error **errp)
{
- StringOutputVisitor *sov = DO_UPCAST(StringOutputVisitor, visitor, v);
+ StringOutputVisitor *sov = to_sov(v);
char *out;
if (sov->human) {
@@ -248,14 +253,14 @@ static void print_type_str(Visitor *v, char **obj, const
char *name,
static void print_type_number(Visitor *v, double *obj, const char *name,
Error **errp)
{
- StringOutputVisitor *sov = DO_UPCAST(StringOutputVisitor, visitor, v);
+ StringOutputVisitor *sov = to_sov(v);
string_output_set(sov, g_strdup_printf("%f", *obj));
}
static void
start_list(Visitor *v, const char *name, Error **errp)
{
- StringOutputVisitor *sov = DO_UPCAST(StringOutputVisitor, visitor, v);
+ StringOutputVisitor *sov = to_sov(v);
/* we can't traverse a list in a list */
assert(sov->list_mode == LM_NONE);
@@ -266,7 +271,7 @@ start_list(Visitor *v, const char *name, Error **errp)
static GenericList *
next_list(Visitor *v, GenericList **list, Error **errp)
{
- StringOutputVisitor *sov = DO_UPCAST(StringOutputVisitor, visitor, v);
+ StringOutputVisitor *sov = to_sov(v);
GenericList *ret = NULL;
if (*list) {
if (sov->head) {
@@ -293,7 +298,7 @@ next_list(Visitor *v, GenericList **list, Error **errp)
static void
end_list(Visitor *v, Error **errp)
{
- StringOutputVisitor *sov = DO_UPCAST(StringOutputVisitor, visitor, v);
+ StringOutputVisitor *sov = to_sov(v);
assert(sov->list_mode == LM_STARTED ||
sov->list_mode == LM_END ||
--
2.4.3
- [Qemu-devel] [PULL 17/31] qapi: Prefer type_int64 over type_int in visitors, (continued)
- [Qemu-devel] [PULL 17/31] qapi: Prefer type_int64 over type_int in visitors, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 27/31] qapi: Drop unused error argument for list and implicit struct, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 25/31] qapi: Drop unused 'kind' for struct/enum visit, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 23/31] qom: Swap 'name' next to visitor in ObjectPropertyAccessor, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 04/31] tests: Use Python 2.6 "except E as ..." syntax, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 22/31] qapi: Swap visit_* arguments for consistent 'name' placement, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 15/31] qapi: Track all failures between visit_start/stop, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 11/31] hmp: Cache use of qapi visitor, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 21/31] qom: Use typedef for Visitor, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 24/31] qapi: Swap 'name' in visit_* callbacks to match public API, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 06/31] qapi: Avoid use of misnamed DO_UPCAST(),
Markus Armbruster <=
- [Qemu-devel] [PULL 19/31] qapi: Consolidate visitor small integer callbacks, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 18/31] qapi: Make all visitors supply uint64 callbacks, Markus Armbruster, 2016/02/09
- [Qemu-devel] [PULL 31/31] qapi: Add missing JSON files in build dependencies, Markus Armbruster, 2016/02/09
- Re: [Qemu-devel] [PULL 00/31] QAPI patches for 2016-02-09, Peter Maydell, 2016/02/09