Re: [Qemu-devel] [PATCH v2 00/10] hw/sd: QOMify sd.c (and pxa2xx_mmci)

[Kevin O'Connor]

On Fri, Jan 22, 2016 at 04:16:32PM +0000, Peter Maydell wrote:
> This series attempts to QOMify sd.c (the actual SD card model),
> including a proper QOM bus between the controller and the card.
> 
> This series removes the experimental x-drive property on sdhci-pci;
> the syntax for using that device changes:
> 
> instead of using the x-drive property:
> 
>   -device sdhci-pci,x-drive=mydrive -drive id=mydrive,[...]
> 
> we create a specific sd device (which is autoplugged into the
> sdhci-pci device's "sd-bus" bus if you don't manually connect them):
> 
>   -device sdhci-pci -drive id=mydrive,[...] -device sd-card,drive=mydrive
> 

FWIW, the series looks fine to me.

Thanks,
-Kevin