[Qemu-devel] [PATCH COLO-Frame v14 39/40] COLO: flush buffered packets in checkpoint process or exit COLO

[zhanghailiang]

In COLO periodic mode, the packets from VM should not be sent
during the time interval of two checkpoints, we will release
all these buffered packets after the checkpoint process, before
VM is resumed.

In this way, we can ensure not to break the network services if
COLO goes into failover process.

Signed-off-by: zhanghailiang <address@hidden>
Cc: Jason Wang <address@hidden>
Cc: Yang Hongyang <address@hidden>
---
v14:
 - New patch
---
 migration/colo.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/migration/colo.c b/migration/colo.c
index 86a7638..afbb0e1 100644
--- a/migration/colo.c
+++ b/migration/colo.c
@@ -118,6 +118,19 @@ static void colo_set_filter_status(NetFilterState *nf, 
void *opaque,
     object_property_set_str(OBJECT(nf), status, "status", errp);
 }
 
+static void colo_flush_filter_packets(NetFilterState *nf, void *opaque,
+                                      Error **errp)
+{
+    char colo_filter[128];
+    char *name = object_get_canonical_path_component(OBJECT(nf));
+
+    snprintf(colo_filter, sizeof(colo_filter), "%scolo", nf->netdev_id);
+    if (strcmp(colo_filter, name)) {
+        return;
+    }
+    filter_buffer_flush(nf);
+}
+
 static void primary_vm_do_failover(void)
 {
     MigrationState *s = migrate_get_current();
@@ -154,6 +167,7 @@ static void primary_vm_do_failover(void)
     if (local_err) {
         error_report_err(local_err);
     }
+    qemu_foreach_netfilter(colo_flush_filter_packets, NULL, NULL);
 
     /* Notify COLO thread that failover work is finished */
     qemu_sem_post(&s->colo_sem);
@@ -361,6 +375,8 @@ static int colo_do_checkpoint_transaction(MigrationState *s,
     if (local_err) {
         goto out;
     }
+    /* FIXME: Remove this after switch to use colo-proxy */
+    qemu_foreach_netfilter(colo_flush_filter_packets, NULL, NULL);
 
     if (colo_shutdown_requested) {
         colo_put_cmd(s->to_dst_file, COLO_MESSAGE_GUEST_SHUTDOWN, &local_err);
-- 
1.8.3.1