Re: [Qemu-devel] [RFC 09/14] Implement remaining PMU functionality

[Alistair Francis]

On Wed, Feb 3, 2016 at 10:37 AM, Peter Maydell <address@hidden> wrote:
> On 2 February 2016 at 23:22, Alistair Francis <address@hidden> wrote:
>> On Tue, Feb 2, 2016 at 3:01 PM, Christopher Covington
>> <address@hidden> wrote:
>>> As for the status of our TCG PMU patches, unfortunately, last I recall,
>>> I was writing some kvm-unit-tests that Drew wanted me to test against
>>> the KVM PMU, which required real hardware. I got distracted with using
>>> an upstream kernel and a certain distribution on the hardware and have
>>> yet to return.
>>
>> That's unfortunate. Could this patch be split out and applied by itself?
>
> That sounds like a good idea. It needs splitting up into more
> digestible chunks for review as well.

Ok, I had a look at the patch. It is massive, it touches so much code!

I split out a few things and I will send a patch set for that. It
includes the part that I am most interested in, but doesn't do any of
the timer changes or interrupts that you did.

Thanks,

Alistair

>
> thanks
> -- PMM