[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to a
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] m68k: Build the opcode table only once to avoid multithreading issues |
|
Date: |
Wed, 3 Feb 2016 10:39:13 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
Le 03/02/2016 10:37, John Paul Adrian Glaubitz a écrit :
> Signed-off-by: John Paul Adrian Glaubitz <address@hidden>
> ---
> target-m68k/translate.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 535d7f9..f508d1e 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -2828,6 +2828,10 @@ register_opcode (disas_proc proc, uint16_t opcode,
> uint16_t mask)
> Later insn override earlier ones. */
> void register_m68k_insns (CPUM68KState *env)
> {
> + /* Build the opcode table only once to avoid
> + issues with multithreading. */
> + if(opcode_table[0] != NULL)
> + return;
> #define INSN(name, opcode, mask, feature) do { \
> if (m68k_feature(env, M68K_FEATURE_##feature)) \
> register_opcode(disas_##name, 0x##opcode, 0x##mask); \
>
Reviewed-by: Laurent Vivier <address@hidden>