[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mappin
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU |
Date: |
Wed, 03 Feb 2016 10:04:08 +0100 |
Hi,
> +static void intel_igd_opregion_setup(struct pci_device *dev, void *arg)
> +{
> + struct romfile_s *file = romfile_find("etc/igd-opregion");
Is it possible to have multiple igd devices in a single machine?
So, should we include the pci address in the file name?
Guess not needed, it's chipset graphics after all ...
> + pci_config_writel(bdf, 0xFC, cpu_to_le32((u32)opregion));
Looks a bit funny in code which is never ever going to run on big endian
machines ;)
Patch looks good to me.
cheers,
Gerd
- [Qemu-devel] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU, Alex Williamson, 2016/02/02
- Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU,
Gerd Hoffmann <=
- Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU, Alex Williamson, 2016/02/03
- Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU, Alex Williamson, 2016/02/03
- Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU, Kevin O'Connor, 2016/02/03
- Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU, Alex Williamson, 2016/02/03
- Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU, Gerd Hoffmann, 2016/02/04
- Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU, Kevin O'Connor, 2016/02/04
Re: [Qemu-devel] [SeaBIOS] [RFC PATCH v2] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU, Igor Mammedov, 2016/02/04