Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 02/02/2016 01:04 PM, Markus Armbruster wrote:
>> Eric Blake <address@hidden> writes:
>> 
>>> Commit 86f4b687 broke compilation on sparc, which has a preprocessor
>>> pollution of '#define sparc 1'.  Treat it the same way as we do for
>>> the pollution with 'unix', so that QMP remains backwards compatible
>>> and only the C code needs to use the alternative 'q_sparc' spelling.
>>>
>>> CC: Peter Maydell <address@hidden>
>>> Signed-off-by: Eric Blake <address@hidden>
>>> ---
>>>
>>> Done as a followup to the same style of patch for MIPS; or we could
>>> squash this into one patch.
>> 
>> Applied to qapi-next squashed:
>> 
>>     qapi: Fix compilation failure on MIPS and SPARC
>>     
>>     Commit 86f4b687 broke compilation on MIPS and SPARC, which have a
>>     preprocessor pollution of '#define mips 1' and '#define space 1',
>
> s/space/sparc/
>
>>     respectively.  Treat it the same way as we do for the pollution with
>>     'unix', so that QMP remains backwards compatible and only the C code
>>     needs to use the alternative 'q_mips' spelling.
>>     
>>     CC: James Hogan <address@hidden>
>>     CC: Peter Maydell <address@hidden>
>>     Signed-off-by: Eric Blake <address@hidden>
>>     Tested-by: James Hogan <address@hidden>
>>     Signed-off-by: Markus Armbruster <address@hidden>
>> 

Fixed up and pushed again.  Thanks!