[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v10 1/2] mirror: Rewrite mirror_iteration
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v10 1/2] mirror: Rewrite mirror_iteration |
Date: |
Wed, 3 Feb 2016 09:47:38 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, 02/02 18:20, Max Reitz wrote:
> On 13.01.2016 03:50, Fam Zheng wrote:
> > The "pnum < nb_sectors" condition in deciding whether to actually copy
> > data is unnecessarily strict, and the qiov initialization is
> > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard.
> >
> > Rewrite mirror_iteration to fix both flaws.
> >
> > The output of iotests 109 is updated because we now report the offset
> > and len slightly differently in mirroring progress.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block/mirror.c | 333
> > +++++++++++++++++++++++++++------------------
> > tests/qemu-iotests/109.out | 80 +++++------
> > trace-events | 1 -
> > 3 files changed, 242 insertions(+), 172 deletions(-)
>
> Unfortunately, this patch now conflicts with your series that added the
> @file parameter to bdrv_get_block_status():
Thanks, I will send V11.
Fam