qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc
Date: Tue, 2 Feb 2016 15:00:07 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0

On 02/02/2016 01:04 PM, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> 
>> Commit 86f4b687 broke compilation on sparc, which has a preprocessor
>> pollution of '#define sparc 1'.  Treat it the same way as we do for
>> the pollution with 'unix', so that QMP remains backwards compatible
>> and only the C code needs to use the alternative 'q_sparc' spelling.
>>
>> CC: Peter Maydell <address@hidden>
>> Signed-off-by: Eric Blake <address@hidden>
>> ---
>>
>> Done as a followup to the same style of patch for MIPS; or we could
>> squash this into one patch.
> 
> Applied to qapi-next squashed:
> 
>     qapi: Fix compilation failure on MIPS and SPARC
>     
>     Commit 86f4b687 broke compilation on MIPS and SPARC, which have a
>     preprocessor pollution of '#define mips 1' and '#define space 1',

s/space/sparc/

>     respectively.  Treat it the same way as we do for the pollution with
>     'unix', so that QMP remains backwards compatible and only the C code
>     needs to use the alternative 'q_mips' spelling.
>     
>     CC: James Hogan <address@hidden>
>     CC: Peter Maydell <address@hidden>
>     Signed-off-by: Eric Blake <address@hidden>
>     Tested-by: James Hogan <address@hidden>
>     Signed-off-by: Markus Armbruster <address@hidden>
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]