qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 0/2] Active commit regression fix


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v2 0/2] Active commit regression fix
Date: Tue, 2 Feb 2016 18:08:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 02.02.2016 02:33, Jeff Cody wrote:
> Changes from v1:
> 
> * Rather than allow insertion when bs->device_listtqe_prev points to
>   a NULL entry, make sure than we follow the block scheme of enforcing
>   bs->device_list->tqe_prev is NULL upon deletion. (Thanks Max!)
> 
> Bug #1300209 is a regression in 2.5, introduced during the 
> change away from bdrv_swap().
> 
> When we change the parent backing link (change_parent_backing_link),
> we must also accomodate non-NULL tqe_prev pointers that point to a
> NULL entry.  Please see patch #1 for more details.
> 
> Jeff Cody (2):
>   block: set device_list.tqe_prev to NULL on BDS removal
>   block: qemu-iotests - add test for snapshot, commit, snapshot bug
> 
>  block.c                    |  24 ++++++----
>  blockdev.c                 |   3 +-
>  include/block/block.h      |   1 +
>  tests/qemu-iotests/143     | 114 
> +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/143.out |  24 ++++++++++
>  tests/qemu-iotests/group   |   1 +
>  6 files changed, 155 insertions(+), 12 deletions(-)
>  create mode 100755 tests/qemu-iotests/143
>  create mode 100644 tests/qemu-iotests/143.out

Thanks, applied to my block tree:

https://github.com/XanClic/qemu/commits/block

Max

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]