[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 00/16] block: Rework bdrv_close_all()
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v8 00/16] block: Rework bdrv_close_all() |
Date: |
Fri, 29 Jan 2016 14:45:11 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.01.2016 um 18:59 hat Max Reitz geschrieben:
> Currently, bdrv_close_all() force-closes all BDSs with a BlockBackend,
> which can lead to data corruption (see the iotest added in the final
> patch of this series) and is most certainly very ugly.
>
> This series reworks bdrv_close_all() to instead eject the BDS trees from
> all BlockBackends and then close the monitor-owned BDS trees, which are
> the only BDSs without a BB. In effect, all BDSs are closed just by
> getting closed automatically due to their reference count becoming 0.
>
> Note that the approach taken here leaks all BlockBackends. This does not
> really matter, however, since qemu is about to exit anyway.
Apart from patch 5:
Reviewed-by: Kevin Wolf <address@hidden>
- Re: [Qemu-devel] [PATCH v8 12/16] blockdev: Keep track of monitor-owned BDS, (continued)
[Qemu-devel] [PATCH v8 10/16] block: Make bdrv_close() static, Max Reitz, 2016/01/27
[Qemu-devel] [PATCH v8 13/16] block: Add blk_remove_all_bs(), Max Reitz, 2016/01/27
[Qemu-devel] [PATCH v8 14/16] block: Rewrite bdrv_close_all(), Max Reitz, 2016/01/27
[Qemu-devel] [PATCH v8 16/16] iotests: Add test for block jobs and BDS ejection, Max Reitz, 2016/01/27
[Qemu-devel] [PATCH v8 15/16] iotests: Add test for multiple BB on BDS tree, Max Reitz, 2016/01/27
Re: [Qemu-devel] [PATCH v8 00/16] block: Rework bdrv_close_all(),
Kevin Wolf <=