[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu-upstream compile failure in intel_iommu.c:vtd_cont
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] qemu-upstream compile failure in intel_iommu.c:vtd_context_device_invalidate |
|
Date: |
Thu, 28 Jan 2016 09:45:25 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 27/01/2016 19:23, Olaf Hering wrote:
>
> xen.git/tools/qemu-xen-dir/hw/i386/intel_iommu.c: In function
> ‘vtd_context_device_invalidate’:
> xen.git/tools/qemu-xen-dir/hw/i386/intel_iommu.c:911:46: error: ‘mask’ may be
> used uninitialized in this function [-Werror=maybe-uninitialized]
> if (vtd_as && ((devfn_it & mask) == (devfn & mask))) {
> ^
> It works with -O2. From the code flow its clear that mask is always
> initialized. Looks like gcc 5.2.1 does no proper diagnostic at -O1.
> What should be done with such issues, are they fixed in the code?
It's probably simplest to add a
default:
abort();
to the switch statement above.
Paolo